-
Notifications
You must be signed in to change notification settings - Fork 675
Prepare to migrate to NHCB by updating mixins #13400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…e the classic/native histograms toggle
|
So far, focused on converting the below functions to their native histogram versions:
In the following .libsonnet files:
And updating associated recording rules, plus recording native histogram versions when we can in This affects the following dashboards, but there may still be panels in these dashboards that need updating:
It covered the following metrics (non-exhaustive list):
|
| }, | ||
| }, | ||
| { | ||
| alert: $.alertName('KVStoreFailureNativeHistogram'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at MimirRequestErrors, no need to add suffix "NativeHistogram" , but we do need another label called histogram with classic or native as value as appropriate. Labels will make it possible to route the alerts as we need.
# Conflicts: # development/mimir-microservices-mode/docker-compose.jsonnet # development/mimir-microservices-mode/docker-compose.yml # operations/mimir-mixin/dashboards/dashboard-utils.libsonnet
Signed-off-by: György Krajcsovits <[email protected]>
What this PR does
Start to migrate to NHCB:
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. If changelog entry is not needed, please add thechangelog-not-neededlabel to the PR.about-versioning.mdupdated with experimental features.