BootStrap init closure servletContext cleanup

[gsartori]

See: apache/grails-forge#507 (review)

[CLAassistant]

All committers have signed the CLA.

[matrei]

Hmm, why are we injecting something that is not used?
Why are we even having a BootStrap class that does nothing?

[jdaugherty]

We generate a bootstrap class by default. Maybe we should do what spring does and just combine bootstrap with he application class @matrei

[gsartori]

I've used the code as generated by the (newly refactored) Grails 7 BootStrap template. The injection is not used but it documents how to inject the ServletContext. True it may be removed in those BootStraps that actually contain code.

[matrei]

We generate a bootstrap class by default.

@jdaugherty I think it's fine when we generate starter apps. But why keep it around if it is not used?

The BootStrap vs Application is also another discussion. Right now, the Application class is almost always just a boilerplate that adds nothing other than that is has to be there.

[jdaugherty]

My only concern with removing classes that we generate is we diverge from how people are likely setting up grails apps. There are a lot of ASTs and injecting of functionality in grails. This has the potential to not be testing what people are using. I'd leave bootstrap so we stay true to what most grails apps look like - even if it is empty.

[jdaugherty]

@matrei per discussion, I've taken this discussion to a ticket longer term: apache/grails-core#14021

[jdaugherty]

@gsartori please feel free to merge this in the mean time.

[gsartori]

I cannot see the merge button, I may not have the rightrs to merge the PR (?)