chore!: Require jsoo >= 6.0 #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @hhugo. Do you need this merged/released soon? We still need to figure out some CI issues for this project but I don't have much time in the next two weeks. |
I'm trying to bump jsoo-compiler version in grain. Nothing urgent. |
ospencer
approved these changes
May 15, 2025
|
@hhugo I rebased this and it should be good to go after CI checks :D |
|
Looks like the tests failed on Windows, with opam. We'll need to figure out what's going on there. |
|
I have a branch with this all working somewhere I'll try and get a pr up tonight. |
spotandjake
added a commit
to spotandjake/binaryen.ml
that referenced
this pull request
May 17, 2025
This supersedes grain-lang#211 in switching to jsoo 6, the main difference is we need to be using a later version of node on our opam workflows, similar to the changes required here grain-lang/libbinaryen#114
ospencer
pushed a commit
that referenced
this pull request
May 18, 2025
* chore!: Require jsoo >= 6.0 This supersedes #211 in switching to jsoo 6, the main difference is we need to be using a later version of node on our opam workflows, similar to the changes required here grain-lang/libbinaryen#114 * chore: Remove jsoo changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure what to do with esy.lock changes