-
Notifications
You must be signed in to change notification settings - Fork 155
Document apiVersion 0.0.7, specVersion 0.0.5 and receipts in mappings #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Just warning for the reviewers, this shouldn't be merged until this is in the Hosted Service, for now it's only on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, excited for this one!
Is there a performance penalty of defining |
hey @tuler it requires an additional RPC call, so there will be an impact, but we have not yet got metrics for that |
Hey, is this available yet for the hosted service? |
Hey @ammanpashasc yes it is, are you having trouble with it? |
Hey, yeah so I've upgraded to [email protected] and also updated the specVersion to 0.0.5 and apiVersion to 0.0.7. But when I try to add the
This is what my
Any idea what I'm doing wrong? Edit: nvm, my bad. Had to upgrade the packages to |
This PR briefly documents the changes introduced in graphprotocol/graph-node#3373.
I'm not sure if those changes are enough for it to be considered to be final, so I'll be happy to refine this PR based on the team's suggestions.
The feature PR linked above contains lots of extra detail if more context is needed.