Skip to content

Conversation

tilacog
Copy link
Contributor

@tilacog tilacog commented Apr 1, 2022

This PR briefly documents the changes introduced in graphprotocol/graph-node#3373.

I'm not sure if those changes are enough for it to be considered to be final, so I'll be happy to refine this PR based on the team's suggestions.

The feature PR linked above contains lots of extra detail if more context is needed.

@tilacog tilacog requested a review from a team as a code owner April 1, 2022 23:33
@evaporei
Copy link
Contributor

evaporei commented Apr 1, 2022

Just warning for the reviewers, this shouldn't be merged until this is in the Hosted Service, for now it's only on the master branch of graph-node.

@azf20
Copy link
Contributor

azf20 commented Apr 19, 2022

Thanks @tilacog @evaporei! Just a ping to make sure we remember to merge this when the above are deployed

Copy link
Contributor

@azf20 azf20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, excited for this one!

@azf20 azf20 merged commit a8cfa34 into main May 3, 2022
@azf20 azf20 deleted the tiago/transaction-receipts-in-mappings branch May 3, 2022 14:15
@tuler
Copy link

tuler commented May 3, 2022

Is there a performance penalty of defining receipt: true?

@azf20
Copy link
Contributor

azf20 commented May 4, 2022

hey @tuler it requires an additional RPC call, so there will be an impact, but we have not yet got metrics for that

@ammanpashasc
Copy link

Hey, is this available yet for the hosted service?

@azf20
Copy link
Contributor

azf20 commented May 13, 2022

Hey @ammanpashasc yes it is, are you having trouble with it?

@ammanpashasc
Copy link

ammanpashasc commented May 18, 2022

Hey @ammanpashasc yes it is, are you having trouble with it?

Hey, yeah so I've upgraded to [email protected] and also updated the specVersion to 0.0.5 and apiVersion to 0.0.7. But when I try to add the receipt: true to event mapping, it gives me error:

Path: dataSources > 0 > mapping > eventHandlers > 0
Unexpected key in map: receipt 

This is what my .yaml file looks like:

   - kind: ethereum/contract
    ......
      eventHandlers:
        - event: Assign(indexed address,uint256)
          handler: handleAssign
          receipt: true
      file: ./src/mappings/mapping.ts

Any idea what I'm doing wrong?


Edit: nvm, my bad. Had to upgrade the packages to [email protected] and [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants