Skip to content

update boba network #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 5, 2022
Merged

update boba network #119

merged 4 commits into from
May 5, 2022

Conversation

alexandriaroberts
Copy link
Contributor

@alexandriaroberts alexandriaroberts commented May 4, 2022 •
edited
Loading

@alexandriaroberts alexandriaroberts requested a review from a team as a code owner May 4, 2022 23:04
IainM22
IainM22 approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@IainM22 IainM22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

benface
benface approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@benface benface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Would it be possible to increase the gap between the last line of networks and the *In beta note? It looks a little bit too small to me.

@alexandriaroberts
Copy link
Contributor Author

LGTM! Would it be possible to increase the gap between the last line of networks and the *In beta note? It looks a little bit too small to me.

I have increased the gap and updated font-size as well which was asked before by Carl in here. https://app.asana.com/0/1199528735768693/1201841234561069/f

@alexandriaroberts alexandriaroberts requested a review from benface May 5, 2022 01:17
benface
benface reviewed May 5, 2022
View reviewed changes
benface
benface approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@benface benface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the gap! 👍

@alexandriaroberts alexandriaroberts merged commit 649496d into main May 5, 2022
@alexandriaroberts alexandriaroberts deleted the lexie/boba-netwrk branch May 5, 2022 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benface benface benface approved these changes

@nenadjaja nenadjaja Awaiting requested review from nenadjaja

+1 more reviewer

@IainM22 IainM22 IainM22 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexandriaroberts @benface @IainM22