Skip to content

Conversation

kamilkisiela
Copy link
Contributor

No description provided.

@kamilkisiela kamilkisiela requested a review from a team as a code owner June 29, 2022 14:39
```

> Please note that some suffixes are only supported for specific types. For example, `Boolean` only supports `_not`, `_in`, and `_not_in`.
> Please note that some suffixes are only supported for specific types. For example, `Boolean` only supports `_not`, `_in`, and `_not_in`, but `_` is available only for object and interface types.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that Arrays of Objects aren't supported, for example?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I described here only the output types of GraphQL, both NonNullable and List are just modifiers. Maybe it's misleading? On the other hand, if we mention here the List modifier, then the NonNullable modifier is equal from the GraphQL standpoint and worth including as well, but then it becomes too complex.

Not sure, your choice :)

}
```

#### Example for child entity filtering
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if "nested" entities is easier to understand? Is there a general term for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, nested makes more sense to me as well.

@kamilkisiela
Copy link
Contributor Author

@azf20 I think we can merge it now, no?

Copy link
Contributor

@azf20 azf20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@azf20 azf20 merged commit a70a1f6 into graphprotocol:main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants