Skip to content

Conversation

dimitrovmaksim
Copy link
Member

No description provided.

@dimitrovmaksim dimitrovmaksim requested a review from a team as a code owner July 4, 2022 07:42

In some cases, you will want to deploy the same subgraph to multiple Ethereum networks without duplicating all of its code. The main challenge that comes with this is that the contract addresses on these networks are different.

### graph-cli >=0.29.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change this heading since the options were only added in v0.32.0 for graph deploy?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure about that either, because the options are available in graph-cli for the build command since v0.29.0, we just made them available for deploy too, and now you can use whichever.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or I can change the heading to Using graph-cli and Using templates/templating or something of that sort

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or I can change the heading to Using graph-cli and Using templates/templating or something of that sort

I think that would be better! 👍

@dimitrovmaksim dimitrovmaksim requested a review from benface July 11, 2022 06:37
Copy link
Contributor

@benface benface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@dimitrovmaksim
Copy link
Member Author

This is great, thank you!

Hey, I fixed a merge conflict caused by the new structure PR, fixed a typo and added a Note about the deploy command at the end of the example

Copy link
Contributor

@benface benface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@benface benface merged commit 90e2c3a into graphprotocol:main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants