Fix for arabic translations

[alexandriaroberts]

No description provided.

[benface]

Looks good, just the one comment I left + this little bug that I found on mobile (missing padding):

[alexandriaroberts]

Looks good, just the one comment I left + this little bug that I found on mobile (missing padding):

Thank you, glad this is coming a long. That's good fine, thank you! I have updated it. I will also send Ahmad the latest staging and ask for his opinion with this. :)

[benface]

Thanks for fixing the padding issue!

There's one more thing, sorry for not noticing before... this is kinda nitpicky, but I wonder if the diamond next to the active nav item should be on the right end side, to keep the logic consistent with ltr languages. Notice how there's padding on the left of the nav in English to make space for the diamonds, and that padding is also on the left in Arabic, but perhaps it should be on the right? I think this would be especially beneficial on mobile, where the diamond currently ends up pretty far from the text. We could do this in a separate PR, let me know what you think.

[alexandriaroberts]

Thanks for fixing the padding issue!

There's one more thing, sorry for not noticing before... this is kinda nitpicky, but I wonder if the diamond next to the active nav item should be on the right end side, to keep the logic consistent with ltr languages. Notice how there's padding on the left of the nav in English to make space for the diamonds, and that padding is also on the left in Arabic, but perhaps it should be on the right? I think this would be especially beneficial on mobile, where the diamond currently ends up pretty far from the text. We could do this in a separate PR, let me know what you think.

I understand what you mean, but I am not sure if we should do this just for diamond icon, to me if we are doing this for diamond then shouldn't we do this for all icons? I think we should ask @ahmadmardeni1 for what he thinks to be honest. Because I don't know how would be the understanding arabic user in this all. @ahmadmardeni1 what do you recommend us doing please?

[ahmadmardeni1]

Yes, all diamonds should be on the right side. But on staging everything is back to ltr for some reason:

Can you check so I can take a look? @alexandriaroberts

[alexandriaroberts]

Can you check so I can take a look? @alexandriaroberts

ohh, we need to redeploy the staging. Let me do that and I will message you when it's done @ahmadmardeni1. Thank you for checking this!

[ahmadmardeni1]

I've just checked the new deployment. I think all icons are already on the right side like the search and GitHub icons except for the diamond and yes it should be on the right side. @alexandriaroberts @benface

[ahmadmardeni1]

Just checked, great work! @alexandriaroberts

[benface]

Ready to go! 🚀