Skip to content

Conversation

alexandriaroberts
Copy link
Contributor

Added new video component to the docs, which takes src prop. Moved the styles onto the component in sx and updated the codebase with new Video component.

Screenshot 2022-08-05 at 16 09 00

@alexandriaroberts alexandriaroberts requested a review from a team as a code owner August 5, 2022 08:29
Copy link
Contributor

@hasparus hasparus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I've left one small comment with regards to TypeScript and naming, but I love the cleanup.

Copy link
Contributor

@benface benface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just a couple things: I agree with Piotr's comments and I added some of my own.

Copy link
Contributor

@hasparus hasparus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Contributor

@benface benface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@benface benface merged commit 03b6c5d into main Aug 9, 2022
@benface benface deleted the lexie/video branch August 9, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants