Skip to content

Removed padding for left sidebar elements #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 18, 2022
Merged

Removed padding for left sidebar elements #184

merged 2 commits into from
Aug 18, 2022

Conversation

alexandriaroberts
Copy link
Contributor

This doesn't have a task, removed padding on the sidebar, and the dropdown elements padding so it doesn't look so big and takes so much space.

Screenshot 2022-08-17 at 14 43 45

Screenshot 2022-08-17 at 14 43 56

@alexandriaroberts alexandriaroberts requested a review from a team as a code owner August 17, 2022 06:54
benface
benface approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@benface benface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, but if you'll allow me to be a little nitpicky, I noticed that the space above the "Subgraphs" heading hasn't changed so it now looks a bit too big, compared to the space between a divider and an actual nav item. 🤪

CleanShot 2022-08-17 at 19 40 48@2x

@alexandriaroberts
Copy link
Contributor Author

This looks great, but if you'll allow me to be a little nitpicky, I noticed that the space above the "Subgraphs" heading hasn't changed so it now looks a bit too big, compared to the space between a divider and an actual nav item. 🤪

Ohh I did that intentionally because I thought they were headings so maybe leave out more spacing for them and not nav items. But I will try removing it and see it looks nicer. Thank you. 🙂

@alexandriaroberts alexandriaroberts merged commit aa4ee75 into main Aug 18, 2022
@alexandriaroberts alexandriaroberts deleted the lexie/padding-update branch August 18, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benface benface benface approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandriaroberts @benface