fix some broken images in remote mdx, use ast replacing instead regex #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Next.js Bundle Analysis for @graphprotocol/docsThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
saihaj
approved these changes
Jul 1, 2023
benface
reviewed
Jul 6, 2023
website/src/remarkReplaceLinks.ts
Outdated
Comment on lines
32
to
53
| visit( | ||
| tree, | ||
| [ | ||
| { type: 'mdxJsxTextElement', name: 'img' }, | ||
| { type: 'mdxJsxFlowElement', name: 'img' }, | ||
| ], | ||
| (node: any) => { | ||
| const attrs = node.attributes as { name: string; value: string }[] | ||
| const srcAttr = attrs.find((attr) => attr.name === 'src')! | ||
| if (srcAttr.value.includes('.gitbook/assets/')) { | ||
| srcAttr.value = srcAttr.value.replace( | ||
| /.*\.gitbook\/assets\//, | ||
| `https://raw.githubusercontent.com/${assetsBasePath}.gitbook/assets/` | ||
| ) | ||
| } | ||
| } | ||
| ) | ||
| visit(tree, 'image', (node) => { | ||
| if (node.url.includes('../assets/')) { | ||
| node.url = node.url.replace(/.*\.\.\/assets\//, `https://raw.githubusercontent.com/${assetsBasePath}assets/`) | ||
| } | ||
| }) |
There was a problem hiding this comment.
This is not really about "links"; should it go in a separate Remark plugin?
benface
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
found here https://thegraph.com/docs/en/substreams/concepts-and-fundamentals/fundamentals/ by @saihaj