Skip to content

Conversation

benface
Copy link
Contributor

@benface benface commented Jul 12, 2023

Fixes #417

@benface benface requested a review from a team as a code owner July 12, 2023 02:03
const MobileWrapper = ({ title, children }: PropsWithChildren<{ title?: string }>) => {
const [open, setOpen] = useState(false)
const { t } = useI18n()
const { t } = useI18n<any>()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding any is obviously not a great fix, but it's how useI18n is currently used elsewhere in nextra-theme. I still don't fully understand the point of extracting the theme to a separate package if I'm being completely honest; we wouldn't need to use any if this was in the website package because the translations live there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We extracted it to be possible to install the same theme in another repository? We can back nextra-theme in the website folder if it is no longer the case with remote mdx cc @saihaj

@benface benface requested a review from dimaMachina July 12, 2023 02:13
@benface
Copy link
Contributor Author

benface commented Jul 12, 2023

@B2o5T @saihaj @dotansimha – Do you guys have any idea why the CI is failing with the following error and what we can do about it? I'm able to build the app just fine locally.

  FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
   1: 0xb7a940 node::Abort() [node]
   2: 0xa8e823  [node]
   3: 0xd5c990 v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
   4: 0xd5cd37 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
   5: 0xf3a435  [node]
   6: 0xf3b338 v8::internal::Heap::RecomputeLimits(v8::internal::GarbageCollector) [node]
   7: 0xf4b843  [node]
   8: 0xf4c6b8 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
   9: 0xf2701e v8::internal::HeapAllocator::AllocateRawWithLightRetrySlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [node]
  10: 0xf283e7 v8::internal::HeapAllocator::AllocateRawWithRetryOrFailSlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [node]
  11: 0xf095ba v8::internal::Factory::NewFillerObject(int, v8::internal::AllocationAlignment, v8::internal::AllocationType, v8::internal::AllocationOrigin) [node]
  12: 0x12ce7ff v8::internal::Runtime_AllocateInYoungGeneration(int, unsigned long*, v8::internal::Isolate*) [node]
  13: 0x16fb6f9  [node]
  Aborted (core dumped)
   ELIFECYCLE  Command failed with exit code 134.

@dimaMachina
Copy link
Contributor

@benface don’t know maybe related to updating some dependency

@github-actions

This comment was marked as resolved.

@benface
Copy link
Contributor Author

benface commented Jul 12, 2023

maybe related to updating some dependency

@B2o5T – Could be, but I don't think so because this other PR also just got the same error: https://github.com/graphprotocol/docs/actions/runs/5535418204/jobs/10101686588

@benface
Copy link
Contributor Author

benface commented Jul 12, 2023

OK, fixed the CI error by allowing Node to use more memory. 🥲

@benface
Copy link
Contributor Author

benface commented Jul 12, 2023

@B2o5T @saihaj – This PR is now ready to be reviewed. :)

@benface benface merged commit 35f8d04 into main Jul 13, 2023
@benface benface deleted the benface/develop branch July 13, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix typechek for nextra-theme
2 participants