-
Notifications
You must be signed in to change notification settings - Fork 155
Update dependencies + fix typecheck #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
const MobileWrapper = ({ title, children }: PropsWithChildren<{ title?: string }>) => { | ||
const [open, setOpen] = useState(false) | ||
const { t } = useI18n() | ||
const { t } = useI18n<any>() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding any
is obviously not a great fix, but it's how useI18n
is currently used elsewhere in nextra-theme
. I still don't fully understand the point of extracting the theme to a separate package if I'm being completely honest; we wouldn't need to use any
if this was in the website
package because the translations live there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We extracted it to be possible to install the same theme in another repository? We can back nextra-theme in the website
folder if it is no longer the case with remote mdx cc @saihaj
@B2o5T @saihaj @dotansimha – Do you guys have any idea why the CI is failing with the following error and what we can do about it? I'm able to build the app just fine locally.
|
@benface don’t know maybe related to updating some dependency |
This comment was marked as resolved.
This comment was marked as resolved.
@B2o5T – Could be, but I don't think so because this other PR also just got the same error: https://github.com/graphprotocol/docs/actions/runs/5535418204/jobs/10101686588 |
OK, fixed the CI error by allowing Node to use more memory. 🥲 |
Co-authored-by: Dimitri POSTOLOV <[email protected]>
Fixes #417