Skip to content

Conversation

enoldev
Copy link
Collaborator

@enoldev enoldev commented Sep 21, 2023

No description provided.

@enoldev enoldev requested a review from a team as a code owner September 21, 2023 15:03
@github-actions
Copy link

github-actions bot commented Sep 21, 2023

📦 Next.js Bundle Analysis for @graphprotocol/docs

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 661.31 KB (🟡 +9 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Page Added

The following page was added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/en/firehose 5.72 KB 667.03 KB 190.58%

Thirty-five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/ar/new-chain-integration 7.24 KB 668.55 KB 191.01% (+/- <0.01%)
/cs/new-chain-integration 7.24 KB 668.55 KB 191.01% (+/- <0.01%)
/cs/operating-graph-node 14.65 KB 675.97 KB 193.13% (+/- <0.01%)
/de/new-chain-integration 7.24 KB 668.55 KB 191.01% (+/- <0.01%)
/en/new-chain-integration 7.29 KB 668.6 KB 191.03% (+/- <0.01%)
/en/substreams 6.32 KB 667.63 KB 190.75% (🟡 +0.09%)
/es/cookbook/near 10.58 KB 671.89 KB 191.97% (+/- <0.01%)
/es/new-chain-integration 7.24 KB 668.55 KB 191.01% (+/- <0.01%)
/fr/cookbook/substreams-powered-subgraphs 70.26 KB 731.57 KB 209.02% (+/- <0.01%)
/fr/developing/developer-faqs 10.34 KB 671.66 KB 191.90% (+/- <0.01%)
/fr/network/delegating 9.28 KB 670.59 KB 191.60% (+/- <0.01%)
/fr/new-chain-integration 7.23 KB 668.55 KB 191.01% (+/- <0.01%)
/ha/new-chain-integration 7.24 KB 668.55 KB 191.01% (+/- <0.01%)
/hi/release-notes/graphql-validations-migration-guide 11.08 KB 672.39 KB 192.11% (+/- <0.01%)
/it/new-chain-integration 7.24 KB 668.55 KB 191.01% (+/- <0.01%)
/it/querying/querying-from-an-application 7.7 KB 669.02 KB 191.15% (+/- <0.01%)
/ja/new-chain-integration 7.24 KB 668.55 KB 191.01% (+/- <0.01%)
/ko/new-chain-integration 7.24 KB 668.55 KB 191.01% (+/- <0.01%)
/mr/new-chain-integration 7.24 KB 668.55 KB 191.01% (+/- <0.01%)
/mr/querying/distributed-systems 8.14 KB 669.45 KB 191.27% (+/- <0.01%)
/nl/new-chain-integration 7.24 KB 668.55 KB 191.01% (+/- <0.01%)
/pl/new-chain-integration 7.24 KB 668.55 KB 191.01% (+/- <0.01%)
/pt/new-chain-integration 7.24 KB 668.55 KB 191.01% (+/- <0.01%)
/ro/new-chain-integration 7.24 KB 668.55 KB 191.01% (+/- <0.01%)
/ru/new-chain-integration 7.24 KB 668.55 KB 191.01% (+/- <0.01%)
/sv/new-chain-integration 7.24 KB 668.55 KB 191.01% (+/- <0.01%)
/tr/mips-faqs 8.83 KB 670.14 KB 191.47% (+/- <0.01%)
/tr/new-chain-integration 7.24 KB 668.55 KB 191.01% (+/- <0.01%)
/uk/new-chain-integration 7.24 KB 668.55 KB 191.01% (+/- <0.01%)
/uk/querying/querying-best-practices 10.29 KB 671.6 KB 191.89% (+/- <0.01%)
/ur/cookbook/near 11.4 KB 672.71 KB 192.20% (+/- <0.01%)
/ur/network/curating 11.55 KB 672.86 KB 192.25% (+/- <0.01%)
/ur/new-chain-integration 7.24 KB 668.55 KB 191.01% (+/- <0.01%)
/vi/new-chain-integration 7.24 KB 668.55 KB 191.01% (+/- <0.01%)
/zh/new-chain-integration 7.24 KB 668.55 KB 191.01% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link
Contributor

@benface benface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we also want to update nginx.conf to remove the redirect from /docs/en/firehose/ to $scheme://$http_host/docs/en/firehose/README/ and perhaps add a redirect from /docs/en/firehose/(.+) to https://firehose.streamingfast.io like we did with Substreams?

Copy link
Contributor

@benface benface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@enoldev enoldev merged commit 619e904 into main Sep 28, 2023
@enoldev enoldev deleted the enol/firehose branch September 28, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants