Skip to content

Conversation

charlypoly
Copy link
Contributor

Hi, here Charly from The Guild

@azf20, as discussed together, here is the new content for the "Querying from an Application" documentation page

Let me know how to proceed 👀
Also, how will be handled the existing translated version of the old "Querying from an Application" page?

@charlypoly charlypoly requested a review from a team as a code owner February 14, 2022 17:21
@benface
Copy link
Contributor

benface commented Feb 15, 2022

Hi @charlypoly! About your translations question, I think the right way to proceed would be to overwrite the file in all languages with your changes (so basically duplicate your querying-from-your-app.mdx file in each pages/[language]/developer folder). When this PR is merged, Crowdin will pick up the new source strings so translators will be able to translate them, and subsequently Crowdin will propose changes to the files in the different languages (except English) via a pull request. Does that make sense?

@charlypoly
Copy link
Contributor Author

Hi @charlypoly! About your translations question, I think the right way to proceed would be to overwrite the file in all languages with your changes (so basically duplicate your querying-from-your-app.mdx file in each pages/[language]/developer folder). When this PR is merged, Crowdin will pick up the new source strings so translators will be able to translate them, and subsequently Crowdin will propose changes to the files in the different languages (except English) via a pull request. Does that make sense?

@benface Thanks, it's done!

@charlypoly charlypoly requested review from lutter and removed request for a team February 22, 2022 09:33
Copy link
Contributor

@lutter lutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the additions

Copy link
Contributor

@azf20 azf20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @charlypoly LGTM!

@azf20
Copy link
Contributor

azf20 commented Mar 17, 2022

@benface as discussed this has been moved to be its own separate page, so we can get it merged and translated (and then we can migrate / show it in the navbar). Hope that makes sense! Will hold off merging to check we have done this right 🙏

@benface
Copy link
Contributor

benface commented Mar 18, 2022

This is great @charlypoly and @azf20, thank you!

@charlypoly
Copy link
Contributor Author

Hi @azf20!

Any news on this PR? 👀

@azf20 azf20 merged commit 3ed15ff into graphprotocol:main Apr 20, 2022
@azf20
Copy link
Contributor

azf20 commented Apr 20, 2022

Hey @charlypoly sorry was away these past weeks - back now and merged it, hopefully can get translations up and running and can go into the next release!

@charlypoly
Copy link
Contributor Author

Thank you @azf20!

@charlypoly charlypoly deleted the docs/graphql-query-quickstart branch April 20, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants