Subgraph Best Practices 5 and 6 #825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and added links to bottom of each best practice
idalithb
reviewed
Dec 10, 2024
|
|
||
| ## Subgraph Best Practices 1-6 | ||
|
|
||
| 1. [Improve Query Speed with Subgraph Pruning](https://thegraph.com/docs/en/cookbook/pruning/) |
There was a problem hiding this comment.
All
Suggested change
| 1. [Improve Query Speed with Subgraph Pruning](https://thegraph.com/docs/en/cookbook/pruning/) | |
| 1. [Improve Query Speed with Subgraph Pruning](/cookbook/pruning/) |
You should make this modification to all links
@benface correct me if I'm wrong here
There was a problem hiding this comment.
Links that are within the docs*
There was a problem hiding this comment.
Yes, because absolute links have the language (English) hardcoded in them, whereas relative ones keep the current language (and the href is copied over as-is to translated pages).
|
|
||
| ## Why Timeseries and Aggregations Are a Best Practice | ||
|
|
||
| 1. Improved Indexing Time • Less Data to Load: Mappings handle less data since raw data points are stored as immutable timeseries entities. • Database-Managed Aggregations: Aggregations are automatically computed by the database, reducing the workload on the mappings. |
There was a problem hiding this comment.
Spacing issue that's distorting the formatting. I think the bullet point are suppose to be below the numbers, right?
marcusrein
commented
Dec 11, 2024
There was a problem hiding this comment.
I like your changes @idalithb !
Feel free to move forward with your suggestions. Thank you!
Co-authored-by: Idalith <[email protected]>
…protocol/docs into subgraph-best-practice-5-6
Co-authored-by: Idalith <[email protected]>
Co-authored-by: Idalith <[email protected]>
Co-authored-by: Idalith <[email protected]>
Co-authored-by: Idalith <[email protected]>
Co-authored-by: Idalith <[email protected]>
Co-authored-by: Idalith <[email protected]>
Co-authored-by: Idalith <[email protected]>
Co-authored-by: Idalith <[email protected]>
Co-authored-by: Idalith <[email protected]>
Co-authored-by: Idalith <[email protected]>
Co-authored-by: Idalith <[email protected]>
Co-authored-by: Idalith <[email protected]>
…protocol/docs into subgraph-best-practice-5-6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Subgraph Best Practice 5andSubgraph Best Practice 6after peer review process was completed.Updated formatting and added links to the bottom of each Subgraph Best Practice as well to improve congruency of this cookbook series.
Thanks!