Skip to content

Conversation

dabit3
Copy link
Contributor

@dabit3 dabit3 commented Mar 9, 2022

This pull request adds a new section to the docs, under the Subgraph Studio section, to explain how the subgraph transfer functionality works.

@dabit3 dabit3 requested a review from a team as a code owner March 9, 2022 18:54
Copy link
Contributor

@azf20 azf20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only edit might be to emphasize that ownership of the NFT = control of the subgraph a little more prominently.


The Graph supports the transfer of the ownership of a subgraph.

When you deploy a subgraph to mainnet, an NFT will be minted to the address that deployed the subgraph. Whoever owns the NFT controls the subgraph. The NFT is based on a standard ERC721, so it can be easily transferred to different accounts.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is worth really emphasizing "Whoever owns the NFT controls the subgraph" - essentially if folks sell the NFT, or transfer it, they will no longer be able to make edits or updates to that subgraph on the network

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @azf20 I made some updates around the language here and am pushing up a new commit.

@dabit3 dabit3 merged commit e87d631 into main Mar 10, 2022
@dabit3 dabit3 deleted the nader/subraph-ownership-transfer-docs branch March 10, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants