Add Layout component with sticky header
#88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandriaroberts
changed the title
# Conflicts: # pages/_app.tsx
benface
changed the title
Layout component with sticky header
benface
reviewed
Mar 22, 2022
benface
approved these changes
Mar 22, 2022
benface
added a commit
that referenced
this pull request
Mar 25, 2022
* Remove scroll animation after changing the language or clicking on a link * Update dependencies * Add `Layout` component with sticky header (#88) * imported Layout component * removed container from index file * updated headerSticky prop to true in docs * Fix the build * removed unnecessary div * removed unnecessary div Co-authored-by: Benoît Rouleau <[email protected]> * Update dependencies * SEO / locale fixes * Fix bug where the top half of `NewGDSDivider` is clipped Co-authored-by: Alexandria Roberts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing Layout component here. I just did minimal changed to _app.js file for the background image in div.
Issue: https://app.asana.com/0/1200559321875810/1201921576460054/f