Skip to content

firehose: remove 'to' address on eth trx when root call is CREATE #4085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2022
Merged

firehose: remove 'to' address on eth trx when root call is CREATE #4085

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion chain/ethereum/src/codec.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,19 @@ impl<'a> TryInto<web3::types::Transaction> for TransactionTraceAt<'a> {
.from
.try_decode_proto("transaction from address")?,
),
to: Some(self.trace.to.try_decode_proto("transaction to address")?),
to: match self.trace.calls.len() {
0 => Some(self.trace.to.try_decode_proto("transaction to address")?),
_ => {
match CallType::from_i32(self.trace.calls[0].call_type).ok_or_else(|| {
format_err!("invalid call type: {}", self.trace.calls[0].call_type,)
})? {
CallType::Create => {
None // we don't want the 'to' address on a transaction that creates the contract, to align with RPC behavior
}
_ => Some(self.trace.to.try_decode_proto("transaction to")?),
}
}
},
value: self.trace.value.as_ref().map_or(U256::zero(), |x| x.into()),
gas_price: self.trace.gas_price.as_ref().map(|x| x.into()),
gas: U256::from(self.trace.gas_limit),
Expand Down