Skip to content

Conversation

@hopeyen
Copy link
Contributor

@hopeyen hopeyen commented Feb 2, 2022

Goal

  • Add a filter such that indexer agent reject to allocate unsupported subgraphs (not eligible for indexing rewards)
  • indexers could decide to bypass the filter if desired

Update

  • add additional boolean field requireSupported to IndexingRules
    -- default set to true, such that agent reject unsupported subgraphs by default
    -- new rules are set to true by creation
    instructions
  • if you still want to allocate, bypass the filter by setting requireSupported to false
  • if you just want to deploy, set decisionBasis to offchain

@hopeyen hopeyen force-pushed the hope/require_support_for_denied branch 3 times, most recently from 24158ba to cb29ae2 Compare February 2, 2022 23:12
deploymentRule?.decisionBasis === IndexingDecisionBasis.ALWAYS
) {
// cannot allocate to unsupported subgraph by default
if (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this check should be moved outside of the deploymentRule?.decisionBasis === IndexingDecisionBasis.ALWAYS conditional block, so it stops all types of rules from allocating towards unsupported subgraphs.

@hopeyen hopeyen force-pushed the hope/require_support_for_denied branch 2 times, most recently from d27e95e to 8b454df Compare February 16, 2022 00:01
@fordN fordN force-pushed the hope/require_support_for_denied branch from 8b454df to 80817b8 Compare February 16, 2022 18:45
@hopeyen hopeyen force-pushed the hope/require_support_for_denied branch 5 times, most recently from 6f7cfa2 to 93d2d35 Compare February 18, 2022 19:14
Copy link
Contributor

@fordN fordN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hopeyen hopeyen force-pushed the hope/require_support_for_denied branch from 93d2d35 to e8fb9dc Compare February 22, 2022 22:45
@hopeyen hopeyen merged commit 144996e into main Feb 22, 2022
@fordN fordN deleted the hope/require_support_for_denied branch February 22, 2022 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants