indexer-agent,-service: remove index-node configs #512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fordN
reviewed
Oct 17, 2022
Contributor
fordN
left a comment
fordN
left a comment
There was a problem hiding this comment.
Code looks good! Let's do some testing in a multi indexing node environment to confirm that deployment assignments get properly balanced across the set of index nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove indexer agent's assignments for subgraph deployments to specific index nodes, instead encourages the use of graph-node toml configs for flexible deployment rules.
Currently the indexer agent and service take index-node id as provided at start-up, and round-robin the number of deployments on each node. We would like to make sure that graph node can balance deployments across available index-nodes with flexible deployment rules without conflicts from the agent.
Resolves #504