OverlappingFieldsCanBeMerged RangeError: Maximum call stack size exceeded

[fionawhim]

We saw this in production. Not sure what caused Relay to go all "fundefined" but here's the query:

query Sidebar_route {
  currentAccount {
    id
    ...Fundefined
  }
}

fragment F0 on Project {
  name
  identifier
  platform
  iconUrl
  organization {
    alias
    name
    id
  }
  id
}

fragment Fundefined on Account {
  _projectsundefinedcqQId: projects(first: 100) {
    pageInfo {
      hasNextPage
      hasPreviousPage
    }
    edges {
      node {
        externalId
        name
        identifier
        platform
        organization {
          name
          alias
          id
        }
        id
        ...F0
      }
      cursor
    }
  }
  id
}

fragment Fundefined on Account {
  id
  ...Fundefined
}

And a bit of the stack trace:

RangeError: Maximum call stack size exceeded
RangeError: Maximum call stack size exceeded
at sameArguments (/srv/graphql-server/releases/ac9417eae173c36d5b9d0c6c9315f829ff0c2a63/node_modules/graphql/validation/rules/OverlappingFieldsCanBeMerged.js:444:23) 
at findConflict (/srv/graphql-server/releases/ac9417eae173c36d5b9d0c6c9315f829ff0c2a63/node_modules/graphql/validation/rules/OverlappingFieldsCanBeMerged.js:424:10) 
at /srv/graphql-server/releases/ac9417eae173c36d5b9d0c6c9315f829ff0c2a63/node_modules/graphql/validation/rules/OverlappingFieldsCanBeMerged.js:375:26 
at Array.forEach (native) at collectConflictsBetween (/srv/graphql-server/releases/ac9417eae173c36d5b9d0c6c9315f829ff0c2a63/node_modules/graphql/validation/rules/OverlappingFieldsCanBeMerged.js:369:34) 
at collectConflictsBetweenFieldsAndFragment (/srv/graphql-server/releases/ac9417eae173c36d5b9d0c6c9315f829ff0c2a63/node_modules/graphql/validation/rules/OverlappingFieldsCanBeMerged.js:225:3) 
at collectConflictsBetweenFieldsAndFragment (/srv/graphql-server/releases/ac9417eae173c36d5b9d0c6c9315f829ff0c2a63/node_modules/graphql/validation/rules/OverlappingFieldsCanBeMerged.js:230:5) 
at collectConflictsBetweenFieldsAndFragment (/srv/graphql-server/releases/ac9417eae173c36d5b9d0c6c9315f829ff0c2a63/node_modules/graphql/validation/rules/OverlappingFieldsCanBeMerged.js:230:5) 
at collectConflictsBetweenFieldsAndFragment (/srv/graphql-server/releases/ac9417eae173c36d5b9d0c6c9315f829ff0c2a63/node_modules/graphql/validation/rules/OverlappingFieldsCanBeMerged.js:230:5) 
at collectConflictsBetweenFieldsAndFragment (/srv/graphql-server/releases/ac9417eae173c36d5b9d0c6c9315f829ff0c2a63/node_modules/graphql/validation/rules/OverlappingFieldsCanBeMerged.js:230:5) 
at collectConflictsBetweenFieldsAndFragment (/srv/graphql-server/releases/ac9417eae173c36d5b9d0c6c9315f829ff0c2a63/node_modules/graphql/validation/rules/OverlappingFieldsCanBeMerged.js:230:5) 
at collectConflictsBetweenFieldsAndFragment (/srv/graphql-server/releases/ac9417eae173c36d5b9d0c6c9315f829ff0c2a63/node_modules/graphql/validation/rules/OverlappingFieldsCanBeMerged.js:230:5) 
at collectConflictsBetweenFieldsAndFragment (/srv/graphql-server/releases/ac9417eae173c36d5b9d0c6c9315f829ff0c2a63/node_modules/graphql/validation/rules/OverlappingFieldsCanBeMerged.js:230:5) 
at collectConflictsBetweenFieldsAndFragment (/srv/graphql-server/releases/ac9417eae173c36d5b9d0c6c9315f829ff0c2a63/node_modules/graphql/validation/rules/OverlappingFieldsCanBeMerged.js:230:5) 
at collectConflictsBetweenFieldsAndFragment (/srv/graphql-server/releases/ac9417eae173c36d5b9d0c6c9315f829ff0c2a63/node_modules/graphql/validation/rules/OverlappingFieldsCanBeMerged.js:230:5) 
at collectConflictsBetweenFieldsAndFragment (/srv/graphql-server/releases/ac9417eae173c36d5b9d0c6c9315f829ff0c2a63/node_modules/graphql/validation/rules/OverlappingFieldsCanBeMerged.js:230:5)

I would expect that this query would be rejected on validation rather than causing a recursive stack blowup.

graphql-js v0.6.0

[leebyron]

Thanks for the report! Looks like there should be some sanity checks for fragment recursion that were missed.

[Mickael-van-der-Beek]

@leebyron Can confirm that we saw an identical situation in production.

A shorter example of the proof of concept bug:

query {
  project {
    ...F0
  }
}

fragment F0 on Project {
  ...F0
}

The GraphQL version used is ^0.10.1.

[Mickael-van-der-Beek]

Interestingly, the GraphQL endpoint for GitHub's APIs (https://developer.github.com/v4/explorer/) returns:

{
  "data": null,
  "errors": [
    {
      "message": "Fragment F0 contains an infinite loop",
      "locations": [
        {
          "line": 12,
          "column": 1
        }
      ]
    }
  ]
}

So it seems they are using the Ruby GraphQL driver (https://github.com/rmosolgo/graphql-ruby/) which does check for infinite loops.

code: https://github.com/rmosolgo/graphql-ruby/blob/b8325f9767a2bab4abb6e93bfa33c3b883d3144d/lib/graphql/static_validation/rules/fragments_are_finite.rb#L12
spec: https://github.com/rmosolgo/graphql-ruby/blob/aacf279b0503be80175a8b0f9c32029a8999227e/spec/graphql/static_validation/validator_spec.rb#L44

[OlegIlyenko]

Looks like it's related to this one: #780

[leebyron]

Fixed in master, released shortly