Read-only AST types #1121
Merged
Read-only AST types #1121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Potential breaking change: Where previously AST would produce `null`, it now produces `undefined`** This tightens up the AST types to produce readonly covariant fields, $ReadOnlyArray in a couple places (not AST yet, perhaps in a future PR), and replaces `field?: ?Rule` with `field?: Rule` to exclude the possibility of `null` from `undefined` for optional rules, reducing complexity.
Merged
leebyron
added a commit
that referenced
this pull request
Dec 6, 2017
leebyron
added a commit
that referenced
this pull request
Dec 6, 2017
This is the second step of #1121 to ensure AST are readonly, marking all arrays as $ReadOnlyArray.
leebyron
added a commit
that referenced
this pull request
Dec 6, 2017
This is the second step of #1121 to ensure AST are readonly, marking all arrays as $ReadOnlyArray.
leebyron
added a commit
that referenced
this pull request
Dec 7, 2017
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential breaking change: Where previously AST would produce
null, it now producesundefinedThis tightens up the AST types to produce readonly covariant fields, $ReadOnlyArray in a couple places (not AST yet, perhaps in a future PR), and replaces
field?: ?Rulewithfield?: Ruleto exclude the possibility ofnullfromundefinedfor optional rules, reducing complexity.