Replace all 'Array.forEach' with 'for of' cycle #1423
Merged
+229
−226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mjmahone
for ofis 4x faster thanforEach+ arrow function: https://jsperf.com/for-of-vs-foreach5If we enable
loosemode forfor ofthan it will be 12x speedup.Also,
for ofdon't force us to create closures so it should lower memory usage in recursive functions.But more importantly, the main purpose of this library is to be the reference implementation of GraphQL so code readability is very important.