Add Node Predicates #1459
Merged
Add Node Predicates #1459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanGoncharov
force-pushed
the
addNodePredicates
branch
from
818e878 to
6b0ec5e
Compare
mjmahone
requested changes
Aug 9, 2018
| import type { ASTNode } from './ast'; | ||
| import { Kind } from './kinds'; | ||
|
|
||
| export function isDefinitionNode(node: ASTNode): boolean %checks { |
There was a problem hiding this comment.
I am a big fan of these! We hit them a lot, and it's nice to be able to filter through definitions to just get Executable or TypeSystem definitions!
| definition.kind !== Kind.OPERATION_DEFINITION && | ||
| definition.kind !== Kind.FRAGMENT_DEFINITION | ||
| ) { | ||
| if (!isExecutableDefinitionNode(node)) { |
There was a problem hiding this comment.
The flow error here is because you're asking if the Document is an ExecutableDefinitionNode rather than asking if the definition is.
There was a problem hiding this comment.
@mjmahone Fixed. Thanks.
IvanGoncharov
force-pushed
the
addNodePredicates
branch
from
6b0ec5e to
234d8e5
Compare
mjmahone
approved these changes
Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For SDL validation rules I need to distinguish type definition node from type extension nodes.
+ I saw same in couple other projects, e.g.
relay:https://github.com/facebook/relay/blob/04aac482538b83548c25e878205ecc1a581bcb25/packages/graphql-compiler/core/GraphQLSchemaUtils.js#L198-L203