Add missing handling for recording encryption configs and keys #57279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eriktate
force-pushed
the
eriktate/refactor-encrypted-recording-protos
branch
from
3c160d0 to
e99bcc2
Compare
eriktate
force-pushed
the
eriktate/add-tags-to-encryption-keys
branch
from
f454db6 to
8101eed
Compare
…usting pkcs11 host UUID check to allow for key sharing of encryption keys, preventing cloud tenants from enabling manual key management
eriktate
force-pushed
the
eriktate/add-tags-to-encryption-keys
branch
from
8101eed to
28c2293
Compare
eriktate
requested review from
russjones,
r0mant,
zmb3,
rosstimothy,
hugoShaka,
tigrato,
strideynet,
klizhentas,
fheinecke,
camscale and
doggydogworld
as code owners
|
@eriktate - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
eriktate
force-pushed
the
eriktate/refactor-encrypted-recording-protos
branch
from
e99bcc2 to
7b9deac
Compare
eriktate
removed request for
klizhentas,
r0mant,
tigrato,
russjones,
zmb3,
strideynet,
hugoShaka and
fheinecke
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few missing pieces to recording encryption:
manual_key_management