Configure test suite for edge-endpoint support #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyler-romero
commented
Dec 7, 2023
Contributor
blaise-muhirwa
left a comment
blaise-muhirwa
left a comment
There was a problem hiding this comment.
Looks good! Should we remove the filters for the docs make targets?
| assert is_valid_display_result(_image_query.result) | ||
|
|
||
|
|
||
| @pytest.mark.skip_for_edge_endpoint(reason="The edge-endpoint does not support passing metadata.") |
Contributor
There was a problem hiding this comment.
As we were mentioned yesterday I think, we can also easily support this once we have persistent storage for image queries on the edge.
Contributor
Author
There was a problem hiding this comment.
Yeah but for now we want to unblock other PRs on the edge. And in general we may not be fully feature complete on the edge relative to the cloud.
blaise-muhirwa
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The edge-endpoint doesn't support the full suite of sdk features (e.g. no metadata support due to the lack of any persistence). This allows us to make tests that are edge-specific or edge-incompatible.