Adds whoami function #176
Merged
Adds whoami function #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robotrapta
approved these changes
Feb 17, 2024
Member
robotrapta
left a comment
robotrapta
left a comment
There was a problem hiding this comment.
This is great! Is this just using the current /me endpoint used by reef? And this is almost all generated code?
Also we should use this call in Groundlight._verify_connectivity instead of list_detectors and then we can remember who the logged in user is, and include that in the __repr__ string so if you say
gl = groundlight.Groundlight()
print(gl)
it prints out the currently logged in username. Doesn't need to be in this PR.
Collaborator
Author
There was a problem hiding this comment.
Yeah, it's mostly generated! It's neat how powerful the openapi standard is, and since we have the /me endpoint for reef this turns out to be super straightforward.
I like the rec on _verify_connectivity and __repr__, I'll add those in the next PR
…e package.json (and all of the generated code accordingly)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Feature request: Whoami? #64