Restoring timeout functionality #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robotrapta
approved these changes
Mar 15, 2024
Member
robotrapta
left a comment
robotrapta
left a comment
There was a problem hiding this comment.
While you're in here, could you change the DEFAULT_REQUEST_TIMEOUT to 10s? We saw some failures at 5s where it would have finished and succeeded given a bit longer.
Contributor
Author
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #168, Leo added faster HTTP timeouts, which was very helpful because the defaults are way too long.
In #164, I was overzealous in my code deletion and accidentally removed it. This PR restores it.
Also, I found a breaking change between 0.14.0 and the RPC server/URCap. When there is no active inspection on the URCap, it sends an empty string for the inspection_id. URScript does not have the notion of None or null, or even optional arguments, so this seems to be the best we can do. Previously, the API would accept an empty string for the inspection_id, but the new API endpoint returns the following response: HTTP response body: {"inspection_id":["This field may not be blank."]}
This has been tested on the URCap/RPC server and works as expected.