Add experimental support for creating multi-class detectors #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyler-romero
force-pushed
the
tyler/multiclass-detector-support
branch
from
63601cc to
bb9fa6e
Compare
brandon-wada
approved these changes
Oct 9, 2024
Collaborator
brandon-wada
left a comment
brandon-wada
left a comment
There was a problem hiding this comment.
Looks good, sans one nit and your second PR to enable the tester
test/unit/test_experimental.py
Outdated
| name, "What kind of dog is this?", class_names=class_names | ||
| ) | ||
| assert created_detector is not None | ||
| count_iq = gl_experimental.submit_image_query(created_detector, "test/assets/dog.jpeg") |
Collaborator
There was a problem hiding this comment.
Nit, it's not a count_iq
tyler-romero
commented
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the format for creating a multi-class detector w/ class_names, and add a function to the experimental part of the sdk to explicitly support this.