Fixing bad breaking bug in endpoint url sanitization #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robotrapta
commented
Mar 31, 2023
| # Specify the endpoint | ||
| self.endpoint = sanitize_endpoint_url(endpoint) | ||
| configuration = Configuration(host=endpoint) | ||
| configuration = Configuration(host=self.endpoint) |
Member
Author
There was a problem hiding this comment.
The missing self. here was actually the entirety of the bug. The rest of this PR is cleaning up tests and making it a bit more robust.
robotrapta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A funny-to-me set of coincidences let this bug through all our tests. The endpoint sanitizer was well tested in unit tests, but the integration wasn't quite right, and the integration tests skipped the sanitizer. That's fixed now. As is the bug.