Bounding box mode detector creation #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandon-wada
approved these changes
May 1, 2025
Collaborator
brandon-wada
left a comment
brandon-wada
left a comment
There was a problem hiding this comment.
Looks good, my main issue is with the TODO, but the code here right now is good
src/groundlight/experimental_api.py
Outdated
| metadata=metadata, | ||
| ) | ||
| detector_creation_input.mode = ModeEnum.BOUNDING_BOX | ||
| # TODO: pull the BE defined default |
Collaborator
There was a problem hiding this comment.
Do we need to pull it, or can you just submit with a null value here and serverside we interpret that as the default value
Contributor
Author
There was a problem hiding this comment.
Good point, I modeled this off of count mode but I think we can just submit the null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function to the experimental API to create bounding box mode detectors. This mode is not currently enabled for general usage, so the tests are disabled for now.