Standardized linting and formatting #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyler-romero
approved these changes
Apr 14, 2023
Contributor
tyler-romero
left a comment
tyler-romero
left a comment
There was a problem hiding this comment.
Great job adding some polish. Just a couple small nits and questions but lgtm!
Co-authored-by: Tyler Romero <[email protected]>
tyler-romero
pushed a commit
that referenced
this pull request
Dec 6, 2024
Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together. Updates `path-to-regexp` from 0.1.10 to 1.9.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/pillarjs/path-to-regexp/releases">path-to-regexp's releases</a>.</em></p> <blockquote> <h2>Fix backtracking in 1.x</h2> <p><strong>Fixed</strong></p> <ul> <li>Add backtrack protection to 1.x release (<a href="https://redirect.github.com/pillarjs/path-to-regexp/issues/320">#320</a>) 925ac8e</li> <li>Fix <code>re.exec(&[#39](https://github.com/pillarjs/path-to-regexp/issues/39);/test/route&[#39](https://github.com/pillarjs/path-to-regexp/issues/39);)</code> result (<a href="https://redirect.github.com/pillarjs/path-to-regexp/issues/267">#267</a>) 32a14b0</li> </ul> <p><a href="https://github.com/pillarjs/path-to-regexp/compare/v1.8.0...v1.9.0">https://github.com/pillarjs/path-to-regexp/compare/v1.8.0...v1.9.0</a></p> <h2>Backport token to function options</h2> <p><strong>Added</strong></p> <ul> <li>Backport <code>TokensToFunctionOptions</code></li> </ul> <h2>Fix backtracking (again)</h2> <p><strong>Fixed</strong></p> <ul> <li>Improved backtracking protection for 0.1.x, will break some previously valid paths (see previous advisory: <a href="https://github.com/pillarjs/path-to-regexp/security/advisories/GHSA-9wv6-86v2-598j">https://github.com/pillarjs/path-to-regexp/security/advisories/GHSA-9wv6-86v2-598j</a>)</li> </ul> <p><a href="https://github.com/pillarjs/path-to-regexp/compare/v0.1.11...v0.1.12">https://github.com/pillarjs/path-to-regexp/compare/v0.1.11...v0.1.12</a></p> <h2>Error on bad input</h2> <p><strong>Changed</strong></p> <ul> <li>Add error on bad input values 8f09549</li> </ul> <p><a href="https://github.com/pillarjs/path-to-regexp/compare/v0.1.10...v0.1.11">https://github.com/pillarjs/path-to-regexp/compare/v0.1.10...v0.1.11</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pillarjs/path-to-regexp/blob/master/History.md">path-to-regexp's changelog</a>.</em></p> <blockquote> <h1>Moved to <a href="https://github.com/pillarjs/path-to-regexp/releases">GitHub Releases</a></h1> <h2>3.0.0 / 2019-01-13</h2> <ul> <li>Always use prefix character as delimiter token, allowing any character to be a delimiter (e.g. <code>/:att1-:att2-:att3-:att4-:att5</code>)</li> <li>Remove <code>partial</code> support, prefer escaping the prefix delimiter explicitly (e.g. <code>\\/(apple-)?icon-:res(\\d+).png</code>)</li> </ul> <h2>2.4.0 / 2018-08-26</h2> <ul> <li>Support <code>start</code> option to disable anchoring from beginning of the string</li> </ul> <h2>2.3.0 / 2018-08-20</h2> <ul> <li>Use <code>delimiter</code> when processing repeated matching groups (e.g. <code>foo/bar</code> has no prefix, but has a delimiter)</li> </ul> <h2>2.2.1 / 2018-04-24</h2> <ul> <li>Allow empty string with <code>end: false</code> to match both relative and absolute paths</li> </ul> <h2>2.2.0 / 2018-03-06</h2> <ul> <li>Pass <code>token</code> as second argument to <code>encode</code> option (e.g. <code>encode(value, token)</code>)</li> </ul> <h2>2.1.0 / 2017-10-20</h2> <ul> <li>Handle non-ending paths where the final character is a delimiter <ul> <li>E.g. <code>/foo/</code> before required either <code>/foo/</code> or <code>/foo//</code> to match in non-ending mode</li> </ul> </li> </ul> <h2>2.0.0 / 2017-08-23</h2> <ul> <li>New option! Ability to set <code>endsWith</code> to match paths like <code>/test?query=string</code> up to the query string</li> <li>New option! Set <code>delimiters</code> for specific characters to be treated as parameter prefixes (e.g. <code>/:test</code>)</li> <li>Remove <code>isarray</code> dependency</li> <li>Explicitly handle trailing delimiters instead of trimming them (e.g. <code>/test/</code> is now treated as <code>/test/</code> instead of <code>/test</code> when matching)</li> <li>Remove overloaded <code>keys</code> argument that accepted <code>options</code></li> <li>Remove <code>keys</code> list attached to the <code>RegExp</code> output</li> <li>Remove asterisk functionality (it's a real pain to properly encode)</li> <li>Change <code>tokensToFunction</code> (e.g. <code>compile</code>) to accept an <code>encode</code> function for pretty encoding (e.g. pass your own implementation)</li> </ul> <h2>1.7.0 / 2016-11-08</h2> <ul> <li>Allow a <code>delimiter</code> option to be passed in with <code>tokensToRegExp</code> which will be used for "non-ending" token match situations</li> </ul> <h2>1.6.0 / 2016-10-03</h2> <ul> <li>Populate <code>RegExp.keys</code> when using the <code>tokensToRegExp</code> method (making it consistent with the main export)</li> <li>Allow a <code>delimiter</code> option to be passed in with <code>parse</code></li> <li>Updated TypeScript definition with <code>Keys</code> and <code>Options</code> updated</li> </ul> <h2>1.5.3 / 2016-06-15</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pillarjs/path-to-regexp/commit/c75eb105b2a177822c1dfd58e0e032320cd868ff"><code>c75eb10</code></a> 1.9.0</li> <li><a href="https://github.com/pillarjs/path-to-regexp/commit/925ac8e3c5780b02f58cbd4e52f95da8ad2ac485"><code>925ac8e</code></a> Add backtrack protection to 1.x release (<a href="https://redirect.github.com/pillarjs/path-to-regexp/issues/320">#320</a>)</li> <li><a href="https://github.com/pillarjs/path-to-regexp/commit/32a14b0185ab23c1afae6dd7b624a01ce68fd470"><code>32a14b0</code></a> Fix <code>re.exec('/test/route')</code> result (<a href="https://redirect.github.com/pillarjs/path-to-regexp/issues/267">#267</a>)</li> <li><a href="https://github.com/pillarjs/path-to-regexp/commit/79a5dcf5f2a79a99fbaaccae20cd922a745e0f83"><code>79a5dcf</code></a> 1.8.0</li> <li><a href="https://github.com/pillarjs/path-to-regexp/commit/1a47442831b795a9d25efc7ea666dcb2c4c01833"><code>1a47442</code></a> feat: backport TokensToFunctionOptions to v1.x</li> <li><a href="https://github.com/pillarjs/path-to-regexp/commit/9c0550cc0b647a39ec7e52d0deda279e6302e547"><code>9c0550c</code></a> Update history for <code>1.7.0</code></li> <li><a href="https://github.com/pillarjs/path-to-regexp/commit/a99ec3c149e8c1d91fa533aa54d3ee7e34449bb3"><code>a99ec3c</code></a> v1.7.0</li> <li><a href="https://github.com/pillarjs/path-to-regexp/commit/69fb61b9560429d3eeedd3756e92a343cd0488bd"><code>69fb61b</code></a> Allow delimiter to be set for <code>tokensToRegExp</code></li> <li><a href="https://github.com/pillarjs/path-to-regexp/commit/1c2e8e4f2326cbad7125f5b28bd1839b7e12c8bc"><code>1c2e8e4</code></a> Update history for <code>1.6.0</code></li> <li><a href="https://github.com/pillarjs/path-to-regexp/commit/bdf17de3dfcf62b410e7cab15998c6e32361c7f9"><code>bdf17de</code></a> v1.6.0</li> <li>Additional commits viewable in <a href="https://github.com/pillarjs/path-to-regexp/compare/v0.1.10...v1.9.0">compare view</a></li> </ul> </details> <br /> Updates `express` from 4.21.1 to 4.21.2 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/expressjs/express/releases">express's releases</a>.</em></p> <blockquote> <h2>4.21.2</h2> <h2>What's Changed</h2> <ul> <li>Add funding field (v4) by <a href="https://github.com/bjohansebas"><code>@bjohansebas</code></a> in <a href="https://redirect.github.com/expressjs/express/pull/6065">expressjs/express#6065</a></li> <li>deps: [email protected] by <a href="https://github.com/blakeembrey"><code>@blakeembrey</code></a> in <a href="https://redirect.github.com/expressjs/express/pull/5956">expressjs/express#5956</a></li> <li>deps: bump [email protected] by <a href="https://github.com/jonchurch"><code>@jonchurch</code></a> in <a href="https://redirect.github.com/expressjs/express/pull/6209">expressjs/express#6209</a></li> <li>Release: 4.21.2 by <a href="https://github.com/UlisesGascon"><code>@UlisesGascon</code></a> in <a href="https://redirect.github.com/expressjs/express/pull/6094">expressjs/express#6094</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/expressjs/express/compare/4.21.1...4.21.2">https://github.com/expressjs/express/compare/4.21.1...4.21.2</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/expressjs/express/blob/4.21.2/History.md">express's changelog</a>.</em></p> <blockquote> <h1>4.21.2 / 2024-11-06</h1> <ul> <li>deps: [email protected] <ul> <li>Fix backtracking protection</li> </ul> </li> <li>deps: [email protected] <ul> <li>Throws an error on invalid path values</li> </ul> </li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/expressjs/express/commit/1faf228935aa0a13111f92c28ee795be64ce3f0f"><code>1faf228</code></a> 4.21.2</li> <li><a href="https://github.com/expressjs/express/commit/2e0fb646d03184dd9a5285813460210c0e7ae654"><code>2e0fb64</code></a> deps: bump [email protected] (<a href="https://redirect.github.com/expressjs/express/issues/6209">#6209</a>)</li> <li><a href="https://github.com/expressjs/express/commit/59fc27028ec5d212be653d35d7e3f73a2c3ac3c0"><code>59fc270</code></a> deps: [email protected] (<a href="https://redirect.github.com/expressjs/express/issues/5956">#5956</a>)</li> <li><a href="https://github.com/expressjs/express/commit/51fc39ccf834eec44547b0f4fed8027e7c05a009"><code>51fc39c</code></a> docs: add funding (<a href="https://redirect.github.com/expressjs/express/issues/6065">#6065</a>)</li> <li>See full diff in <a href="https://github.com/expressjs/express/compare/4.21.1...4.21.2">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~jonchurch">jonchurch</a>, a new releaser for express since your current version.</p> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/groundlight/python-sdk/network/alerts). </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tyler Romero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package should be passing all linter and formatting checks now! I also made a few improvements on makefiles, readmes, and documentation.