Skip to content

Conversation

@ejona86
Copy link
Member

@ejona86 ejona86 commented Sep 16, 2024

Needs to add @experimentalapi to public classes until goes through a grpc design review

See comments on: #11113 most importantly:

  • Need to eliminate all blocking
  • Need to close channels when no longer needed (ProtocolNegotiator.close() was called)
  • Need to document where all certs came from

CC @rmehta19

@ejona86
Copy link
Member Author

ejona86 commented Sep 16, 2024

The failures are because #11528 needs to go in.

@ejona86 ejona86 merged commit c92453f into grpc:master Sep 24, 2024
15 checks passed
@ejona86 ejona86 deleted the s2a-nopublish branch September 24, 2024 22:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants