core: TimeProvider should not assume that the clock never changes #4883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should reflect changes in the system clock.
| public long currentTimeNanos() { | ||
| return System.nanoTime() + offsetNanos; | ||
| return TimeUnit.MILLISECONDS.toNanos(System.currentTimeMillis()); | ||
| } |
Contributor
There was a problem hiding this comment.
After your change, it will return the same nano value for any invocation that happens within one millisecond.
dapengzhang0
approved these changes
Nov 20, 2018
Contributor
dapengzhang0
left a comment
dapengzhang0
left a comment
There was a problem hiding this comment.
LGTM
We can merge this first and fix #5056 later.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should reflect changes in the system clock.