grpc-loader: Expose method options #2711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murgatroid99
requested changes
Apr 8, 2024
Member
murgatroid99
left a comment
murgatroid99
left a comment
There was a problem hiding this comment.
Thank you for the PR. This addresses a lot of the concerns I had with the previous attempt. You will need to fix the CLA issues before I can accept it.
murgatroid99
reviewed
Apr 8, 2024
murgatroid99
approved these changes
Apr 9, 2024
Member
murgatroid99
left a comment
murgatroid99
left a comment
There was a problem hiding this comment.
Thank you for fixing this up. It looks good now.
This was referenced May 23, 2024
This was referenced May 31, 2024
This was referenced Jun 12, 2024
This was referenced Jun 13, 2024
This was referenced Jun 20, 2024
|
Hi, I noticed the link to MethodOptions in the PR description points to the main branch, which has since changed. Here is the permanent link to the file as it existed around the time this PR was created: MethodOptions Just adding this for future reference so others can find the correct context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for MethodOptions to proto-loader.
It is a continuation of #2230 (originally written by @hiepthai) which tries to address the comments of @murgatroid99.