grpc-js: Implement ORCA server-side per-call metrics #2978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the server-side per-call metrics part of gRFC A51. This adds the channel option
grpc.server_call_metric_recordingwhich enables the feature on the server, and adds thegetMetricsRecordermethod to thecallobject that is passed to each method handler. The metrics recorder object has the exact API described in the gRFC.This feature is the first instance of an xds proto being used in the core library, and they need to be published in the library. I already had those protos available in a submodule in the
grpc-js-xdsdirectory, so I added a pre-build script to copy the relevant files into thegrpc-jsdirectory.