gRPC Java S2A protos #149
Merged
gRPC Java S2A protos #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the PR! This change LGTM. Please fix the CLA issue, remove the "draft" piece from the title, and in the PR description can we link to https://github.com/google/s2a-go/blob/main/README.md ? |
Contributor
Author
|
@matthewstevenson88 Thanks for the review! Done. |
Contributor
|
LGTM. Please get approval from @ejona86 as well. (I think I technically have the permission to approve this, but I'm not one of the normal maintainers of this repo so I'd like to get Eric's sign-off that he is OK with where we put the protos.) |
ejona86
reviewed
Apr 29, 2024
ejona86
reviewed
Apr 29, 2024
ejona86
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: