Skip to content

Adds SecurityDetails.subjectAlternativeNames #2820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Adds SecurityDetails.subjectAlternativeNames #2820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d80d0f
Adds SecurityDetails.subjectAlternativeNames
Nov 6, 2024
9c40781
Patch version bump
Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/PuppeteerSharp/PuppeteerSharp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
<Description>Headless Browser .NET API</Description>
<PackageId>PuppeteerSharp</PackageId>
<PackageReleaseNotes></PackageReleaseNotes>
<PackageVersion>20.0.4</PackageVersion>
<ReleaseVersion>20.0.4</ReleaseVersion>
<AssemblyVersion>20.0.4</AssemblyVersion>
<FileVersion>20.0.4</FileVersion>
<PackageVersion>20.0.5</PackageVersion>
<ReleaseVersion>20.0.5</ReleaseVersion>
<AssemblyVersion>20.0.5</AssemblyVersion>
<FileVersion>20.0.5</FileVersion>
<SynchReleaseVersion>false</SynchReleaseVersion>
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<DebugType>embedded</DebugType>
Expand Down
21 changes: 21 additions & 0 deletions lib/PuppeteerSharp/SecurityDetails.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,27 @@ public SecurityDetails()
/// <param name="validTo">Valid to.</param>
/// <param name="protocol">Protocol.</param>
public SecurityDetails(string subjectName, string issuer, long validFrom, long validTo, string protocol)
: this(subjectName, issuer, validFrom, validTo, protocol, [])
{
}

/// <summary>
/// Initializes a new instance of the <see cref="SecurityDetails"/> class.
/// </summary>
/// <param name="subjectName">Subject name.</param>
/// <param name="issuer">Issuer.</param>
/// <param name="validFrom">Valid from.</param>
/// <param name="validTo">Valid to.</param>
/// <param name="protocol">Protocol.</param>
/// <param name="subjectAlternativeNames">Subject alternative names.</param>
public SecurityDetails(string subjectName, string issuer, long validFrom, long validTo, string protocol, string[] subjectAlternativeNames)
{
SubjectName = subjectName;
Issuer = issuer;
ValidFrom = validFrom;
ValidTo = validTo;
Protocol = protocol;
SubjectAlternativeNames = subjectAlternativeNames;
}

/// <summary>
Expand Down Expand Up @@ -59,5 +74,11 @@ public SecurityDetails(string subjectName, string issuer, long validFrom, long v
/// </summary>
/// <value>The protocol.</value>
public string Protocol { get; set; }

/// <summary>
/// Gets the list of subject alternative names (SANs) of the certificate.
/// </summary>
/// <value>The list of subject alternative names (SANs) of the certificate.</value>
public string[] SubjectAlternativeNames { get; set; }
}
}
Loading