Use type forwarding for IsExternalInit on .net8 target #2823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kblok
approved these changes
Nov 13, 2024
Contributor
Author
|
3 tests failed:
Seems like they are flaky ones and not related to the changes. @kblok what do you think ? |
Member
Yeah. I ignored those tests in the v21 branch. This is ready to be merged. This is not blocking you, right? Do you need this shipped now? |
Contributor
Author
Yep, it doesn't block me, just wanted to clarify failed tests status. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added conditional compilation to use type forwarding for net8.0 target as suggested here - dotnet/runtime#79082 (comment). Required to correctly handle public init properties.