Bidi: Page Error #3003
Merged
Bidi: Page Error #3003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements page error event handling for the BiDi protocol by adding log entry observation and propagating JavaScript errors through the event system.
Key changes:
- Added log entry event infrastructure through Session and BrowsingContext
- Implemented JavaScript error detection and stack trace formatting in BidiFrame
- Updated test expectations to enable PageError tests for BiDi
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/PuppeteerSharp/Bidi/Core/Session.cs | Added LogEntryAdded event and observer registration |
| lib/PuppeteerSharp/Bidi/Core/BrowsingContext.cs | Added Log event and filtering logic for context-specific entries |
| lib/PuppeteerSharp/Bidi/BidiPage.cs | Exposed OnPageError method for internal use |
| lib/PuppeteerSharp/Bidi/BidiFrame.cs | Implemented JavaScript error handling with stack trace formatting |
| lib/PuppeteerSharp.Tests/PageTests/PageEventsPageErrorTests.cs | Refactored test to use TaskCompletionSource and filter for specific error |
| lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json | Removed BiDi failure expectation for PageError tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.