icu-14735 add search & pagination to aliases #2498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lisbet-alvarez
commented
Sep 24, 2024
…he-ui' of https://github.com/hashicorp/boundary-ui into ICU-14735-boundary-pagination-for-the-aliases-page-in-the-ui
|
Thanks for introducing pagination to Aliases 👏 |
ZedLi
reviewed
Sep 25, 2024
Co-authored-by: Dharini Jeeva <[email protected]>
…he-ui' of https://github.com/hashicorp/boundary-ui into ICU-14735-boundary-pagination-for-the-aliases-page-in-the-ui
Co-authored-by: Cameron Perera <[email protected]>
ZedLi
approved these changes
Sep 30, 2024
lisbet-alvarez
deleted the
ICU-14735-boundary-pagination-for-the-aliases-page-in-the-ui
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Closes: https://hashicorp.atlassian.net/browse/ICU-14735
Description
Add search & pagination to aliases.
NOTE: We will need to update db version so it doesn't break for users. (There is a draft pr to do this so we might want to revisit that PR and update it if neccessary).
There will still be some upcoming changes to ensure search & pagination does not break when there are 500k+ aliases.
Screenshots (if appropriate)
Screen.Recording.2024-09-23.at.5.44.45.PM.mov
How to Test
Checklist