feat: 🎸 Populate subject for OIDC account name displays #2757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OIDC accounts are guaranteed to have a subject claim which we should display. Currently we only look at email and full_name which are all optional for OIDC claims. ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-16634
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lisbet-alvarez
approved these changes
Apr 2, 2025
calcaide
approved these changes
Apr 2, 2025
…-page-from-users-accounts
ZedLi
deleted the
ICU-16634-allow-user-to-goto-account-details-page-from-users-accounts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Closes: https://hashicorp.atlassian.net/browse/ICU-16634
Description
OIDC accounts are guaranteed to have a subject claim which we should display. Currently we only look at email and full_name which are all optional for OIDC claims. In many cases, if there were no claims for these optional claims, OIDC accounts under users would show nothing which is not a good experience.
I also added links to the fields which goes directly to the corresponding auth method and account as we only display accounts under an auth method.
Screenshots (if appropriate)
Before:
After:
How to Test
Start up boundary dev and navigate to accounts under users. OIDC should display a name and they all should be able to goto the account directly.
Checklist
[ ] I have added JSON response output for API changes[ ] I have added steps to reproduce and test for bug fixes in the description[ ] I have commented on my code, particularly in hard-to-understand areas