-
Notifications
You must be signed in to change notification settings - Fork 51
ember-intl integration
#2878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ember-intl integration
#2878
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
15cad7c to
d1d171c
Compare
The HDS team decided to go ahead and review/merge without going through the formal RFC process
didoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left minor suggestions
packages/components/src/components/hds/advanced-table/th-resize-handle.hbs
Outdated
Show resolved
Hide resolved
didoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
📌 Summary
If merged, this PR enables
ember-intlfor the components package and translates some of the bare strings. It also sets up linting rules preventing the usage of bare strings.Details
ember-intldependency to both theshowcaseandcomponentsworkspaces.componentsdir in a single en-us.yaml filecomponentscomponentsno-bare-stringswhich prevents untranslated text nodesJira ticket: HDS-4856
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.