Skip to content

Conversation

@zamoore
Copy link
Contributor

@zamoore zamoore commented May 14, 2025

📌 Summary

If merged, this PR enables ember-intl for the components package and translates some of the bare strings. It also sets up linting rules preventing the usage of bare strings.

Details

  • Adds ember-intl dependency to both the showcase and components workspaces.
  • Translated all text nodes in the components dir in a single en-us.yaml file
  • Translated any of the following attributes or HTML properties found in components
    • 'aria-label'
    • 'aria-description'
    • 'title'
    • 'placeholder'
    • 'alt'
    • '@text'
  • Added linting rule to components no-bare-strings which prevents untranslated text nodes

Jira ticket: HDS-4856


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

@vercel
Copy link

vercel bot commented May 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Aug 1, 2025 3:14pm
hds-website ✅ Ready (Inspect) Visit Preview Aug 1, 2025 3:14pm

@zamoore zamoore dismissed aklkv’s stale review August 1, 2025 14:06

The HDS team decided to go ahead and review/merge without going through the formal RFC process

@zamoore zamoore requested review from dchyun and didoo August 1, 2025 14:08
didoo
didoo previously approved these changes Aug 1, 2025
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left minor suggestions

Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@zamoore zamoore merged commit 7ee497e into main Aug 1, 2025
16 checks passed
@zamoore zamoore deleted the zamoore/hds-4856/ember-intl-spike branch August 1, 2025 15:31
@hashibot-hds hashibot-hds mentioned this pull request Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants