-
Notifications
You must be signed in to change notification settings - Fork 51
hds-anchored-position - Fix type issues
#3005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git โ๏ธ
|
cd7bfbb to
88daa47
Compare
4 tasks
shleewhite
previously approved these changes
Jul 10, 2025
Contributor
shleewhite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Likely does need a changeset though because this changes an exported type slightly.
shleewhite
previously approved these changes
Jul 11, 2025
zamoore
previously approved these changes
Jul 11, 2025
didoo
previously approved these changes
Jul 14, 2025
didoo
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ Summary
If merged, this PR would fix a type issue with
FloatingUIOptionsin thehds-anchored-positionmodifier originally caught in #3004๐ ๏ธ Detailed description
In testing the typescript conversion of the

PopoverPrimitivelinting errors were thrown when thearrowSelectoroption was used.This is due to the fact that the
Namedargument of thehds-anchored-positionmodifier includes theFloatingUIOptionstype plus an optional stringarrowSelector. However, thePopoverPrimitive, which uses the modifier, theNamedargument is set to theFloatingUIOptions. This type mismatch causes a type error wheneverarrowSelectoris used.To solve this issue I created a new type
HdsAnchoredPositionOptions, which encapsulates this additional string argument.Any components that leveraged the
hds-anchored-positionmodifier and theFloatingUIOptionstype were updated to use theHdsAnchoredPositionOptionsinstead.๐ External links
Jira ticket: HDS-5091
๐ Component checklist
๐ฌ Please consider using conventional comments when reviewing this PR.
๐ PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.