CodeEditor: indicate that [CE].Title and [CE].Description have bound args
#3068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
didoo
approved these changes
Jul 30, 2025
Contributor
didoo
left a comment
didoo
left a comment
There was a problem hiding this comment.
left two super-nitpicky suggestions, but not blockers at all
| Description?: ComponentLike<HdsCodeEditorDescriptionSignature>; | ||
| Title?: WithBoundArgs< | ||
| typeof HdsCodeEditorTitle, | ||
| 'onInsert' | 'editorId' |
Contributor
There was a problem hiding this comment.
[nit] same order as in the template code
Suggested change
| 'onInsert' | 'editorId' | |
| 'editorId' | 'onInsert' |
| >; | ||
| Description?: WithBoundArgs< | ||
| typeof HdsCodeEditorDescription, | ||
| 'onInsert' | 'editorId' |
Contributor
There was a problem hiding this comment.
Suggested change
| 'onInsert' | 'editorId' | |
| 'editorId' | 'onInsert' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR would fix an issue that came up in the TypeScript showcase project. The CodeEditor component does not correctly indicate that some arguments for the
[CE].Titleand[CE].Descriptionare set by the index component.👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.