tests pass #3089
Merged
tests pass #3089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MelSumner
commented
Aug 6, 2025
MelSumner
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
annawanggg
reviewed
Aug 6, 2025
| test('toggle-icon renders no chevron when hasChevron is set to false', async function (assert) { | ||
| await render( | ||
| hbs`<Hds::Dropdown::Toggle::Icon @icon="user" @text="user menu" id="test-toggle-icon" @hasChevron={{false}} />`, | ||
| hbs`<Hds::Dropdown::Toggle::Icon @icon="more-horizontal" @text="user menu" id="test-toggle-icon" @hasChevron={{false}} />`, |
Contributor
There was a problem hiding this comment.
ooo good catch! i guess we were trying to debug the wrong test the whole time :,) a good learning experience though
annawanggg
approved these changes
Aug 6, 2025
shleewhite
pushed a commit
that referenced
this pull request
Oct 14, 2025
Co-authored-by: Anna Wang <[email protected]> Failing test fixed and reworked the hasChevron() function to more closely align with the syntax of other functions
shleewhite
pushed a commit
that referenced
this pull request
Oct 16, 2025
Co-authored-by: Anna Wang <[email protected]> Failing test fixed and reworked the hasChevron() function to more closely align with the syntax of other functions
shleewhite
pushed a commit
that referenced
this pull request
Oct 16, 2025
feat: update enum and type names for allowed icons tests pass (#3089) Co-authored-by: Anna Wang <[email protected]> Failing test fixed and reworked the hasChevron() function to more closely align with the syntax of other functions feat: update docs to mention more-vertical as well feat: added changeset fix: edited changeset formatting to be more consistent fix: type of allowed icons array fix: website indentation issue
shleewhite
pushed a commit
that referenced
this pull request
Oct 16, 2025
feat: update enum and type names for allowed icons tests pass (#3089) Co-authored-by: Anna Wang <[email protected]> Failing test fixed and reworked the hasChevron() function to more closely align with the syntax of other functions feat: update docs to mention more-vertical as well feat: added changeset fix: edited changeset formatting to be more consistent fix: type of allowed icons array fix: website indentation issue
zamoore
pushed a commit
that referenced
this pull request
Oct 27, 2025
feat: update enum and type names for allowed icons tests pass (#3089) Co-authored-by: Anna Wang <[email protected]> Failing test fixed and reworked the hasChevron() function to more closely align with the syntax of other functions feat: update docs to mention more-vertical as well feat: added changeset fix: edited changeset formatting to be more consistent fix: type of allowed icons array fix: website indentation issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.