Skip to content

AppFrame - Change media queries for sticky header to older syntax (HDS-5304) #3110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025
Merged

AppFrame - Change media queries for sticky header to older syntax (HDS-5304) #3110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hungry-months-kick.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@hashicorp/design-system-components": patch
---

`AppFrame` - Changed media query styles for frame header and sidebar containers to use level 3 vs level 4 CSS syntax
8 changes: 6 additions & 2 deletions packages/components/src/styles/components/app-frame.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@
grid-area: header;

// Make header position sticky/fixed if the viewport height is greater than 480px
@media (height >= 480px) {
// Note: HCP in prod doesn't support newer media queries, so we use the old syntax
// stylelint-disable-next-line media-feature-range-notation
@media (min-height: 480px) {
position: sticky;
top: 0;
right: 0;
Expand All @@ -42,7 +44,9 @@
min-height: 100vh;

// Modify sidenav layout when used together with fixed app-header
@media (height >= 480px) {
// Note: HCP in prod doesn't support newer media queries, so we use the old syntax
// stylelint-disable-next-line media-feature-range-notation
@media (min-height: 480px) {
.hds-app-frame--has-header-with-sidebar & {
top: var(--token-app-header-height);
height: calc(100vh - var(--token-app-header-height));
Expand Down