Skip to content

Conversation

@KristinLBradley
Copy link
Contributor

@KristinLBradley KristinLBradley commented Aug 21, 2025

📌 Summary

If merged, this PR adds a close callback to the AppHeader's yielded :logo block.

👉 Preview: https://hds-showcase-git-kristin-hds-5390-app-header-a-e967b2-hashicorp.vercel.app/layouts/app-frame/frameless/demo-full-app-frame-with-app-header-and-app-side-nav

To test:

  1. Narrow browser window until "Menu" button appears in AppHeader bar (the "mobile" view)
  2. Click "Menu" button to open the mobile menu
  3. Click HomeLink logo in the AppHeader
    Expected: The open menu should close.

🔗 External links


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@vercel
Copy link

vercel bot commented Aug 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Aug 21, 2025 4:59pm
hds-website Ready Ready Preview Aug 21, 2025 4:59pm

@KristinLBradley KristinLBradley changed the title AppHeader - Add close callback to "logo" yielded block (HDS-5390) AppHeader - Add close callback to :logo yielded block (HDS-5390) Aug 21, 2025
@KristinLBradley KristinLBradley marked this pull request as ready for review August 21, 2025 17:14
@KristinLBradley KristinLBradley requested a review from a team as a code owner August 21, 2025 17:14
@KristinLBradley KristinLBradley requested a review from a team August 21, 2025 17:14
@KristinLBradley KristinLBradley merged commit 9622f96 into main Aug 21, 2025
16 checks passed
@KristinLBradley KristinLBradley deleted the kristin/hds-5390-app-header-add-logo-close branch August 21, 2025 18:05
@hashibot-hds hashibot-hds mentioned this pull request Aug 21, 2025
@alex-ju alex-ju added this to the [email protected] milestone Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants