Skip to content

Deprecate HdsModal and HdsFlyout yielded subcomponents #3222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 1, 2025
Merged

Deprecate HdsModal and HdsFlyout yielded subcomponents #3222

merged 7 commits into from
Oct 1, 2025

Conversation

@zamoore
Copy link
Contributor

@zamoore zamoore commented Sep 22, 2025 •
edited by atlassian bot
Loading

📌 Summary

If merged, this PR will remove deprecated yielded subcomponents for the HdsModal and HdsFlyout components.

🔗 External links

Jira ticket: HDS-5508

👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@vercel
Copy link

vercel bot commented Sep 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Oct 1, 2025 11:12pm
hds-website Ready Ready Preview Oct 1, 2025 11:12pm

@hashibot-hds hashibot-hds added the docs-website Content updates to the documentation website label Sep 22, 2025
@zamoore zamoore force-pushed the main-5.0.0 branch 3 times, most recently from 79d8cc2 to 9cce42b Compare September 23, 2025 18:45
@zamoore zamoore force-pushed the zamoore/hds-4671/modal_flyout_deprecated_subcomponents branch from 43bbac5 to 2f8db22 Compare September 23, 2025 19:45
@zamoore zamoore marked this pull request as ready for review September 23, 2025 20:01
@zamoore zamoore requested review from a team as code owners September 23, 2025 20:01
didoo
didoo approved these changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

didoo
didoo requested changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[blocker] sorry I realized only after the approval that part of the documentation for the yielded components was missing, it needs to be restored

@zamoore zamoore force-pushed the zamoore/hds-4671/modal_flyout_deprecated_subcomponents branch from 2f8db22 to 9545c2a Compare September 24, 2025 18:42
@zamoore zamoore requested a review from didoo September 24, 2025 18:52
@zamoore
Copy link
Contributor Author

zamoore commented Sep 24, 2025

[blocker] sorry I realized only after the approval that part of the documentation for the yielded components was missing, it needs to be restored

@didoo Should be all set now

dchyun
dchyun reviewed Sep 24, 2025
View reviewed changes
website/docs/components/modal/partials/code/component-api.md
Copy link
Contributor

@dchyun dchyun Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[todo] Found one reference to the Modal::Body in the how to use docs on line 59.

The `<form>` element should be placed in the `Hds::Modal::Body` subcomponent. We also recommend to associate it to the submit button using the `form` attribute, as shown below.

Copy link
Contributor Author

@zamoore zamoore Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, should be fixed now. Good catch.

@zamoore zamoore force-pushed the zamoore/hds-4671/modal_flyout_deprecated_subcomponents branch from 3fb62ed to 6bde6e4 Compare October 1, 2025 23:08
@zamoore zamoore merged commit fc11843 into main-5.0.0 Oct 1, 2025
8 of 10 checks passed
@zamoore zamoore deleted the zamoore/hds-4671/modal_flyout_deprecated_subcomponents branch October 1, 2025 23:08
@zamoore zamoore mentioned this pull request Oct 1, 2025
Merged
5 tasks
zamoore added a commit that referenced this pull request Oct 2, 2025
@zamoore
Deprecate HdsModal and HdsFlyout yielded subcomponents (#3222)
a6c26d3
zamoore added a commit that referenced this pull request Oct 3, 2025
@zamoore
Deprecate HdsModal and HdsFlyout yielded subcomponents (#3222)
27b70bc
zamoore added a commit that referenced this pull request Oct 3, 2025
@zamoore
Deprecate HdsModal and HdsFlyout yielded subcomponents (#3222)
773a90e
zamoore added a commit that referenced this pull request Oct 6, 2025
@zamoore
Deprecate HdsModal and HdsFlyout yielded subcomponents (#3222)
e8fb0c4
zamoore added a commit that referenced this pull request Oct 7, 2025
@zamoore
Deprecate HdsModal and HdsFlyout yielded subcomponents (#3222)
694434c
zamoore added a commit that referenced this pull request Oct 7, 2025
@zamoore
Deprecate HdsModal and HdsFlyout yielded subcomponents (#3222)
5818e00
zamoore added a commit that referenced this pull request Oct 8, 2025
@zamoore
Deprecate HdsModal and HdsFlyout yielded subcomponents (#3222)
fda7639
zamoore added a commit that referenced this pull request Oct 9, 2025
@zamoore
Deprecate HdsModal and HdsFlyout yielded subcomponents (#3222)
874d18c
zamoore added a commit that referenced this pull request Oct 10, 2025
@zamoore
Deprecate HdsModal and HdsFlyout yielded subcomponents (#3222)
3d9159b
zamoore added a commit that referenced this pull request Oct 10, 2025
@zamoore
Deprecate HdsModal and HdsFlyout yielded subcomponents (#3222)
879c323
zamoore added a commit that referenced this pull request Oct 13, 2025
@zamoore
Deprecate HdsModal and HdsFlyout yielded subcomponents (#3222)
e248fb7
zamoore added a commit that referenced this pull request Oct 14, 2025
@zamoore
Deprecate HdsModal and HdsFlyout yielded subcomponents (#3222)
d7df00c
zamoore added a commit that referenced this pull request Oct 27, 2025
@zamoore
Deprecate HdsModal and HdsFlyout yielded subcomponents (#3222)
5736424
zamoore added a commit that referenced this pull request Oct 27, 2025
@zamoore
Deprecate HdsModal and HdsFlyout yielded subcomponents (#3222)
027a2ca
zamoore added a commit that referenced this pull request Oct 28, 2025
@zamoore
Deprecate HdsModal and HdsFlyout yielded subcomponents (#3222)
bb041a6
zamoore added a commit that referenced this pull request Oct 31, 2025
@zamoore
Deprecate HdsModal and HdsFlyout yielded subcomponents (#3222)
b10c224
zamoore added a commit that referenced this pull request Nov 3, 2025
@zamoore
Deprecate HdsModal and HdsFlyout yielded subcomponents (#3222)
a17fc01
aklkv pushed a commit that referenced this pull request Nov 4, 2025
@zamoore @aklkv
Deprecate HdsModal and HdsFlyout yielded subcomponents (#3222)
ba98f51
zamoore added a commit that referenced this pull request Nov 4, 2025
@zamoore
Deprecate HdsModal and HdsFlyout yielded subcomponents (#3222)
6b907ee
zamoore added a commit that referenced this pull request Nov 5, 2025
@zamoore
Deprecate HdsModal and HdsFlyout yielded subcomponents (#3222)
163e511
aklkv pushed a commit that referenced this pull request Nov 9, 2025
@zamoore @aklkv
Deprecate HdsModal and HdsFlyout yielded subcomponents (#3222)
101dbca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@didoo didoo didoo approved these changes

@dchyun dchyun dchyun approved these changes

Assignees

No one assigned

Labels

docs-website Content updates to the documentation website packages/components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zamoore @didoo @dchyun @hashibot-hds