Add ember-basic-dropdown as a peer dependency
#3282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
5 tasks
zamoore
added
release-candidate
Contributor
📦 RC Packages PublishedLatest commit: d140998 Published 2 packages@hashicorp/[email protected]@hashicorp/[email protected] |
zamoore
force-pushed
the
zamoore/hds-5273/ember-basic-dropdown-peer-dep
branch
from
6f64b2b to
ed140af
Compare
zamoore
force-pushed
the
zamoore/hds-5273/ember-basic-dropdown-peer-dep
branch
from
ed140af to
d140998
Compare
zamoore
force-pushed
the
zamoore/hds-5273/ember-basic-dropdown-peer-dep
branch
from
d140998 to
ae0578b
Compare
zamoore
force-pushed
the
zamoore/hds-5273/ember-basic-dropdown-peer-dep
branch
from
ae0578b to
74e6e72
Compare
alex-ju
approved these changes
Oct 10, 2025
Member
alex-ju
left a comment
alex-ju
left a comment
There was a problem hiding this comment.
Left two comments for your consideration
Co-authored-by: Alex <[email protected]>
Co-authored-by: Alex <[email protected]>
5 tasks
zamoore
added a commit
that referenced
this pull request
Oct 10, 2025
Co-authored-by: Alex <[email protected]>
zamoore
added a commit
that referenced
this pull request
Oct 13, 2025
Co-authored-by: Alex <[email protected]>
zamoore
added a commit
that referenced
this pull request
Oct 14, 2025
Co-authored-by: Alex <[email protected]>
zamoore
added a commit
that referenced
this pull request
Oct 27, 2025
Co-authored-by: Alex <[email protected]>
zamoore
added a commit
that referenced
this pull request
Oct 27, 2025
Co-authored-by: Alex <[email protected]>
zamoore
added a commit
that referenced
this pull request
Oct 28, 2025
Co-authored-by: Alex <[email protected]>
zamoore
added a commit
that referenced
this pull request
Oct 31, 2025
Co-authored-by: Alex <[email protected]>
zamoore
added a commit
that referenced
this pull request
Nov 3, 2025
Co-authored-by: Alex <[email protected]>
aklkv
pushed a commit
that referenced
this pull request
Nov 4, 2025
Co-authored-by: Alex <[email protected]>
zamoore
added a commit
that referenced
this pull request
Nov 4, 2025
Co-authored-by: Alex <[email protected]>
zamoore
added a commit
that referenced
this pull request
Nov 5, 2025
Co-authored-by: Alex <[email protected]>
aklkv
pushed a commit
that referenced
this pull request
Nov 9, 2025
Co-authored-by: Alex <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR adds
ember-basic-dropdownas a peer dependency.🛠️ Detailed description
This change addresses a runtime error for consumers of
Hds::Form::SuperSelect. The component relies onember-basic-dropdown, but since it was only adevDependencyin HDS, applications that didn't haveember-basic-dropdowninstalled themselves would encounter a crash. Moving it to a peer dependency ensures that users are notified that they need to install it in order to use HDS.🔗 External links
Jira ticket: HDS-5273
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.